Add AIR compatibility#2934
Open
pw0908 wants to merge 1 commit into
Open
Conversation
wsmoses
approved these changes
Jul 9, 2026
Author
|
@wsmoses Looks like most tests passed. The ones that failed seem to have failed due to air.atan2.f32. Is that a function that is supported normally anyways? |
vchuravy
reviewed
Jul 9, 2026
| // module. Rather than depend on that, these get dedicated blocks so the | ||
| // AIR-named companion (e.g. air.cosh.f32) is created directly on demand, | ||
| // regardless of what else is present in the module. | ||
| def : CallPattern<(Op $x), |
Member
There was a problem hiding this comment.
You are missing air.atan2.f32. here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses EnzymeAD/Enzyme.jl#3289